Skip to content
PR Quorum
Sign inStart free
← Review gallery
astral-sh/uv #20507openreviewed 6h ago

Avoid Tokio startup for synchronous CLI commands

by charliermarsh+324 264 filesreviewed in 3m 43sView PR on GitHub
minor notesThe panel surfaced minor issues worth a look before merge.1 finding

Reviewer panel

Correctness
deepseek/deepseek-v4-flash
errored
Security
deepseek/deepseek-v4-flash
0 found
Architecture
deepseek/deepseek-v4-flash
1 found

Findings

01Llowconf 95%

Duplicated workspace discovery logic in discover_install_path

crates/uv-workspace/src/workspace.rs:302

The new discover_install_path method duplicates a significant portion of the existing Workspace::discover method (lines ~299–410 vs the original async method). Both methods implement the same root-selection, pyproject.toml parsing, workspace membership, and exclusion logic, but one is synchronous and the other async. This duplication creates a maintenance burden: any future change to workspace discovery rules (e.g., new fields, changed exclusion semantics) must be applied in two places, increasing the risk of drift and bugs. Consider refactoring the shared logic into a synchronous helper that both methods can call, or extracting the synchronous core from the async method.

Want this on your own pull requests?
The same reviewer panel runs on every PR — one focused review, no noise.
Start freeLive demo